Page History
| Table of Contents |
|---|
| Jira | ||||||
|---|---|---|---|---|---|---|
|
...
- Use Resources API
- Split scripts vs. classes (scripts stay in current workspace and functionality for executing scripts stay stays in groovy the Groovy module. Support for classes will be removed from Groovy module and placed in resources workspace)
- Maintain support for scripts in JCR > scripts
...
Apparently such classes do appear show up in the Resources App. I created a Groovy script in a package classpath.scripts in Eclipse under src/main/resources
...
The Groovy module replaces Magnolia's DefaultClassFactory with its GroovyClassFactory which internally delegates loading the Groovy source files to MgnlGroovyResourceLoader#loadGroovySource(..). The latter is therefore called very early during Magnolia startup (it is indeed called internally by the GroovyClassLoader) when ResourceOrigin (the entry point for clients of the Resources API) is not ready yet. That would cause a ComponentNotFoundException when NoSuchComponentException when trying to get hold of ResourceOrigin via Components.getComponent(..).
Solution in PoC consists in using a ResourceOriginProvider and skip Groovy resources loading as long as the provider is null. This seems to be safe as during Magnolia's early startup phase there are no Groovy scripts/classes to be instantiated and the loading of Java classes needed by Magnolia is delegated to the parent class loader.
...
- module-names may contain dashes but Java does not allow having a package name with dashes. Scripts (which are eventually compiled as Java classes) need to declare a valid, unique package to compile and for this whole feature to work.
- if module name is in the package name dash ( - ) needs to be replaced (by underscore? or use some other convention)
- next to the templates (convenient to edit, but hard to specify correct package name) vs. special folder (would make it easier to have package name w/o module name in it
- ideally would favor no special tricks
...
As far as I could see, having a special folder in the light module structure, e.g. one called groovy, would not solve the issue because
...
Overview
Content Tools