Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • pass comment on
    • starting the review process
    • rejecting an item

C) Review App

...

  • shows the page
  • workflow actions in the action bar

...

-> see subpage

C) Pulse

  • should a message have a location

 

Jans review notes

  • message is not deleted after approving/rejecting activation
  • message body is silly, it should contain at the very least title of the page and name of the user activating the content if not the link (preview?) of the page
  • when trying to approve already approved workflow error message is displayed in the box, when trying to reject it, error message is displayed in as line under the trinity icons (and in second case also error message is generated and sent)
  • there is no indication of failing activation. When hitting approve on instance w/ missing public, it just seems like activation is working fine.
  • in error messages, stacktrace is wrongly formatted making it impossible to read
  • group deletion works in messages ... well done :D
  • jozef: how do i get workflow definitions out of workflow????
  • bunch of errors when trying to use workflow (see http://pastebin.com/Q40SUHUx )