Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • We cannot use @Theme annotation for third party apps because theme is set on admincentral
  • We use CSSInject to dynamically load an @import rule which references a CSS stylesheet
    • optionally we try to reference a SASS one
  • Create custom annotation @ThemedApp to mark theme
    • Code Block
      languagejava
      @ThemedApp("myapp")
      public class MyApp extends ContentApp {

Decision

-

 

Suggestion box

  • The magnolia theme application could ultimately switch between expected screenshot and actual fields, to help on browser support
  • Structure:

    • magnolia-ui-admincentral
      • @Theme("admincentral") AdmincentralUI
      • themes/admincentral includes magnolia
    • magnolia-ui-vaadin-theme
      • themes/magnolia includes base, commonbase, shellbase
    • magnolia-ui-vaadin-theme-sampler
      • @Theme("themesampler") ThemeSamplerUI
      • themes/themesampler includes magnolia
    • magnolia-ui-vaadin-widgets-common
      • themes/commonbase
    • magnolia-ui-vaadin-widgets-editor
      • themes/pageeditor
    • magnolia-ui-vaadin-widgets-shell
      • themes/shellbase

  • Use CSSInject add-on to support third-party app styles https://vaadin.com/directory#addon/cssinject
    • Inserts styles into <head><style>...</
    • Can load external stylesheets in this manner:  new CSSInject(getUI()).setStyles("@import url('http://theme files/styles.css');");
    • Set this at App level, eventually processing it in BaseApp
  • Enable SASS for STK themes

...