Versions Compared

Old Version 1

changes.mady.by.user Mikaël Geljić

Saved on

compared with

New Version 2

changes.mady.by.user Mikaël Geljić

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • It is hard to relate widget java classes - where style names are set - to their actual CSS rules
  • All stylesheets even for widgets are in the theme directory, which is not necessarly bad but should be reviewed
    • We want these styles to remain dynamically loaded (not processed at GWT compilation time) so that it's easy to develop them
  • We need to review the pattern for applying desktop vs. tablet styles as well
  • Package structure of the common-widgets project could be clearer
  • Naming of widget classes is inconsistent
  • As Sasha pointed out, there may also be room for Optimizing the WidgetSet

Proposal

  • Consider dropping the gwt/public directory for client-side code, and aligning on vaadin7 package structure (client/server/shared)
  • Align naming of widget classes
    • can we use *Widget / *Connector consistently?
    • when do we append the *Widget suffix? (e.g. client-side sub-widgets)
    • can we drop client-side naming *View / *ViewImpl stuff?

...