Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Current Implementation

Proposed Implementation

Additional Information

Documentation

...

Currently the AppFrameView is created and managed by the AppContext.

  • we can simplify the AppContext and remove the dependency on AppFrameView.
  • Inject AppView (interface of AppFrameView) into BaseApp. make start return AppView.
  • add tab etc to the app, delegate to appframeview from there. get

...

  • rid of frameview dependency from appcontroller and appcontext.
  • do not make appContext a listener of appFrameView. app is listening to events and delegates to appContext. get rif of magnoliaTab dependency in the AppFrameView.Listener

Where is mapping between MagnoliaTab and SubApp? -> AppFrameView implementation or SubAppView?

Reintroduce tab to tabId in MagnoliaShell. Use com.vaadin.server.KeyMapper? Kepp in mind that there can be multiple subApps open with subAppId, needs a unique identifier

...

We are using abstract classes where not really no longer necessary. So we end up creating App classes extending AbstractApp, only because the class is abstract.

...