Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • According to Concept - Alternative ui-project organisation
    • move the package info.magnolia.ui.admincentral.app.simple into module magnolia-ui-framework e.g. info.magnolia.ui.framework.app.api (NOTE: this contradicts decision made for shell apps, see further down)
    • or jus out of the simple subpackage
  • info.magnolia.ui.admincentral.app.simple.AppContextImpl
    • general problem: used heavily by the appController and also for the app itself to get contextual information: serving two needs. see http://jira.magnolia-cms.com/browse/MGNLUI-403
      • The idea of AppContext is to expose functionality to the App. That is, to an instance of an app.

        It should not expose methods that are only used by AppControllerImpl. These should be hidden from all other classes.

        If necessary AppControllerImpl#runningApps should be changed to <String, AppContextImpl>. Also if the intention of AppContextImpl is unclear it should be renamed to reflect the fact that is not just the default implementation of AppContext, it does much more and in fact fullfils much of the contract defined by AppController.

      • rename the AppController to AppLauncher or similar, introduce a new AppController class which takes care of the contract to the AppLauncher and keep the AppContext as thin as possible, only serving contextual information to the actual App
      • Move some of the functionality of AppContext into the info.magnolia.ui.framework.app.launcherlayout.AppLauncherGroupEntry
        • info.magnolia.ui.admincentral.app.simple.AppContextImpl#getDefaultSubAppDescriptor
        • info.magnolia.ui.admincentral.app.simple.AppContextImpl#getSubAppDescriptorById

...