Page History

...

• According to Concept - Alternative ui-project organisation
  
  • move the package info.magnolia.ui.admincentral.app.simple into module magnolia-ui-framework e.g. info.magnolia.ui.framework.app.api
  • or jus out of the simple subpackage
• info.magnolia.ui.admincentral.app.simple.AppContextImpl
  • general problem: used heavily by the appController and also for the app itself to get contextual information: serving two needs. see http://jira.magnolia-cms.com/browse/MGNLUI-403
    

    • The idea of AppContext is to expose functionality to the App. That is, to an instance of an app.

      It should not expose methods that are only used by AppControllerImpl. These should be hidden from all other classes.

      If necessary AppControllerImpl#runningApps should be changed to <String, AppContextImpl>. Also if the intention of AppContextImpl is unclear it should be renamed to reflect the fact that is not just the default implementation of AppContext, it does much more and in fact fullfils much of the contract defined by AppController.

    • rename the AppController to AppLauncher or similar, introduce a new AppController class which takes care of the contract to the AppLauncher and keep the AppContext as thin as possible, only serving contextual information to the actual App
      

AppController

...

Cleanup

interface seems fine

usages: MagnoliaShell and MagnoliaShellPresenter, for ChooseDialog in FieldBuilders, AppLauncherShellApp

general question:
usage of FocusEvent: seems to not be used consistently. Could also be extended to get rid of the setViewPort and associated calls

info.magnolia.ui.admincentral.app.simple
move out of simple subpackage

info.magnolia.ui.admincentral.app.simple.AppControllerImpl
interface seems fine

usage of appId is should be changed to appname appName

some methods take the appId and the location as parameter, aphid appId is part of the location
general question:
usage of FocusEvent

info.magnolia.ui.admincentral.app.simple.AppControllerImpl#setViewPortAppControllerImpl#setViewPort
use focus event instead?

info.magnolia.ui.admincentral.app.simple.AppControllerImpl#getAppWithoutStartingAppControllerImpl#getAppWithoutStarting
apparently the idea was to actually start the app for this usage

info.magnolia.ui.admincentral.app.simple.AppControllerImpl#startIfNotAlreadyRunningThenFocusAppControllerImpl#startIfNotAlreadyRunningThenFocus
only used in test cases. see general question about focusEvent

info.magnolia.ui.admincentral.app.simple.AppControllerImpl#startIfNotAlreadyRunningAppControllerImpl#startIfNotAlreadyRunning
deprecated, maybe not right, see focusEvent

info.magnolia.ui.admincentral.app.simple.AppControllerImpl#doStartIfNotAlreadyRunningAppControllerImpl#doStartIfNotAlreadyRunning
this also checks if the app is running, if so it delegates to that app.. wrong naming

info.magnolia.ui.admincentral.app.simple.AppControllerImpl#stopAppAppControllerImpl#stopApp
only used internally

info.magnolia.ui.admincentral.app.simple.AppControllerImpl#onLocationChangedAppControllerImpl#onLocationChanged
too heavy, should delegate to methods rather, see focusEvent

...