Page History
...
The issues are briefly summarised in
Jira | ||||||||
---|---|---|---|---|---|---|---|---|
|
...
Localisation support
- Mess with the interfaces, high level of indirection.
Transformer#hasI18NSupport
,TransformedProperty#hasI18NSupport
which delegates to the first one.- Three objects' methods have to be called so that the new language is applied to a property (
Transformer
,TransformedProperty and DefaultI18NAuthoringSupport
):DefaultI18NAuthoringSupport#constructI18NPropertyName;
Transformer#setI18NPropertyName
;Transformer#setLocale
which simply stores new locale in transformer object;TransformedProperty#fireI18NValueChange
which in reality simply re-reads the value from the transformer.
I18NAuthoringSupport
digs into UI structures code searching for the components with localize-able data-sources.- Logic separation levels breached - ideally Vaadin-agnostic component crawls the UI hierarchy searching for the property data-sources that can be localised;
- Looks cryptic and patchy - one has to know how the forms are composed and how the i18n mechanism is implemented in
Transformers
andTransformedProperty
; - Rigidness and hacks
- instanceof
's checking the abstract objects to belong to concrete types likeBasicTransformer
,TransformedProperty
etc.
- Poor support of multi-field localisation
- The old property transformers do not support i18n and that probably cannot be fixed due to their implementation;
- The new "delegating" transformers do support i18n but internally management of locale-specific data is complicated.
- switching language negatively affects validation.Jira server Magnolia - Issue tracker serverId 500b06a6-e204-3125-b989-2d75b973d05f key MGNLUI-3491
Default values
- Handled only once by the
FieldFactory
object. Later during lifecycle of the field the default value is not resolvable.- Consequence - during change of locale there is no straightforward way to set the default value for a localized property (
).Jira server Magnolia - Issue tracker columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution serverId 500b06a6-e204-3125-b989-2d75b973d05f key MGNLUI-3489
- Consequence - during change of locale there is no straightforward way to set the default value for a localized property (
...
Overview
Content Tools